-
Notifications
You must be signed in to change notification settings - Fork 33
chore(dev-deps): upgrade to svelte-jester 2.0 #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fcdde28
to
3692c3e
Compare
3692c3e
to
38b3031
Compare
@nickmccurdy @MirrorBytes @mihar-22 do you think we could merge this? Thanks! |
LGTM! Need to pull branch and test but I haven't been up to date with |
Hi, sorry for the delay. The I ran the tests locally and they failed with the same issues that I fixed in #161 (Jest 27 no longer loads JSDOM by default). I added those fixes to this branch and the tests are now passing locally. I also cleaned up the test code, I don't think DOM cleanup is necessary since Jest creates new environments between test runs anyway. Please review when you have a chance. |
I got CI working here, but unfortunately it seems like |
Ok, I sent a PR to fix that: svelteness/svelte-jester#83 |
@nickmccurdy I've updated this PR to |
Thanks for the fix! Looks great, we seem to have cut test times in half. |
@all-contributors add @benmccann for tests |
@nickmccurdy I've put up a pull request to add @benmccann! 🎉 |
@all-contributors add @mihar-22 for review |
@nickmccurdy I've put up a pull request to add @mihar-22! 🎉 |
🎉 This PR is included in version 3.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
svelte-jester
2 is a big improvement because it no longer needs to start new node processes thanks to async transformers being added in Jest 27